Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test-stream2-large-read-stall #10725

Closed
wants to merge 1 commit into from
Closed

test: improve test-stream2-large-read-stall #10725

wants to merge 1 commit into from

Conversation

stefanjudis
Copy link
Contributor

@stefanjudis stefanjudis commented Jan 10, 2017 •
edited
Loading

  • use const instead of var
  • use assert.strictEqual instead of assert.equal
  • use common.mustCall instead of process.on( 'exit', fn )
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 10, 2017
@mscdex mscdex added stream Issues and PRs related to the stream subsystem. and removed dont-land-on-v7.x labels Jan 10, 2017
@italoacasas
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/5796/console

@stefanjudis
Copy link
Contributor Author

Hmm... Can I help with the failing build somehow?

make -j4 test succeeds on my machine. :(

@Trott
Copy link
Member

Trott commented Jan 10, 2017

@stefanjudis Looks like the problem is the all-important CERTIFY_SAFE checkbox was not checked when the CI job was kicked off. So, yeah, nothing to worry about. Let's just try again.

CI again: https://ci.nodejs.org/job/node-test-pull-request/5797/

@jasnell
Copy link
Member

jasnell commented Jan 10, 2017

Nope, that was just a oopsie on my part. I forgot to check a checkbox... thanks for restarting @Trott

@stefanjudis
Copy link
Contributor Author

Cool. Thx. 🎉

Can you point me to some info on node's CI infrastructure? I've got no clue what checkbox you're talking about. :)

@Trott
Copy link
Member

Trott commented Jan 10, 2017

Can you point me to some info on node's CI infrastructure? I've got no clue what checkbox you're talking about. :)

You won't be able to see the checkbox without a login on the CI infrastructure, but if you are intensely curious, you can read the docs near the end of the Reviewing PRs section of the onboarding doc.

@italoacasas
Copy link
Contributor

ping @stefanjudis can you rebase please

@stefanjudis
test: improve test-stream2-large-read-stall
d633d3a 
* use const instead of var
* use assert.strictEqual instead of assert.equal
* use  common.mustCall instead of process.on( 'exit', fn )
@stefanjudis
Copy link
Contributor Author

@italoacasas done.

@italoacasas
Copy link
Contributor

Landed c685638

thanks @stefanjudis

italoacasas pushed a commit that referenced this pull request Jan 16, 2017
@stefanjudis @italoacasas
test: improve test-stream2-large-read-stall
c685638 
* use const instead of var
* use assert.strictEqual instead of assert.equal
* use  common.mustCall instead of process.on( 'exit', fn )

PR-URL: #10725
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@stefanjudis stefanjudis deleted the feature/change-var-to-const branch January 16, 2017 22:12
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@stefanjudis @italoacasas
test: improve test-stream2-large-read-stall
e9f5b7c 
* use const instead of var
* use assert.strictEqual instead of assert.equal
* use  common.mustCall instead of process.on( 'exit', fn )

PR-URL: nodejs#10725
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
This was referenced Jan 19, 2017
Closed
Closed
targos pushed a commit that referenced this pull request Jan 28, 2017
@stefanjudis @targos
test: improve test-stream2-large-read-stall
bdc445c 
* use const instead of var
* use assert.strictEqual instead of assert.equal
* use  common.mustCall instead of process.on( 'exit', fn )

PR-URL: #10725
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@stefanjudis @italoacasas
test: improve test-stream2-large-read-stall
46bbabe 
* use const instead of var
* use assert.strictEqual instead of assert.equal
* use  common.mustCall instead of process.on( 'exit', fn )

PR-URL: nodejs#10725
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@stefanjudis @italoacasas
test: improve test-stream2-large-read-stall
ab335fd 
* use const instead of var
* use assert.strictEqual instead of assert.equal
* use  common.mustCall instead of process.on( 'exit', fn )

PR-URL: nodejs#10725
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@stefanjudis @jasnell
test: improve test-stream2-large-read-stall
562f23f 
* use const instead of var
* use assert.strictEqual instead of assert.equal
* use  common.mustCall instead of process.on( 'exit', fn )

PR-URL: #10725
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@stefanjudis @jasnell
test: improve test-stream2-large-read-stall
3c5f65f 
* use const instead of var
* use assert.strictEqual instead of assert.equal
* use  common.mustCall instead of process.on( 'exit', fn )

PR-URL: #10725
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@stefanjudis @MylesBorins
test: improve test-stream2-large-read-stall
b01db3a 
* use const instead of var
* use assert.strictEqual instead of assert.equal
* use  common.mustCall instead of process.on( 'exit', fn )

PR-URL: #10725
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@stefanjudis @MylesBorins
test: improve test-stream2-large-read-stall
ee27917 
* use const instead of var
* use assert.strictEqual instead of assert.equal
* use  common.mustCall instead of process.on( 'exit', fn )

PR-URL: #10725
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italoacasas italoacasas italoacasas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stefanjudis @italoacasas @Trott @jasnell @mscdex @nodejs-github-bot